Return Result to fail gracefully instead of aborting #12409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12409
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 122fe4c with merge base dd4488d ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78187751 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Jul 11, 2025
Summary: - Make TensorInfo static factory pattern to allow returning Result. - Return Result type to fail gracefully instead of directly aborting in the runtime. Differential Revision: D78187751
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78187751 |
JacobSzwejbka
approved these changes
Jul 11, 2025
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Jul 14, 2025
Summary: - Make TensorInfo static factory pattern to allow returning Result. - Return Result type to fail gracefully instead of directly aborting in the runtime. Reviewed By: JacobSzwejbka Differential Revision: D78187751
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78187751 |
Summary: - Make TensorInfo static factory pattern to allow returning Result. - Return Result type to fail gracefully instead of directly aborting in the runtime. Reviewed By: JacobSzwejbka Differential Revision: D78187751
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78187751 |
lucylq
added a commit
that referenced
this pull request
Jul 17, 2025
Differential Revision: D78187751 Pull Request resolved: #12409
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision: D78187751